[tbb-bugs] #28345 [Applications/Tor Browser]: Tor Browser hang on macOS when opening a new tab

[Tor Bug Tracker & Wiki]

#28345: Tor Browser hang on macOS when opening a new tab
------------------------------------------+----------------------
     Reporter:  teor                      |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+----------------------
 My tor browser hung when I tried to open a new tab. So I force quit it.
 Then it crashed.

 A similar bug used to happen reasonably often with Tor Browser 7.5. But I
 don't know how to reproduce it.

 {{{
 Path:                  /Applications/TorBrowser.app/Contents/MacOS/firefox
 ...
 Version:               8.0.2 (6018.2.4)
 ...
 Date/Time:             2018-11-06 15:01:57.535 +1000
 OS Version:            Mac OS X 10.13.6 (17G65)
 Report Version:        12
 Bridge OS Version:     3.0 (14Y664)
 ...
 System Integrity Protection: enabled

 Crashed Thread:        0  Dispatch queue: com.apple.main-thread

 Exception Type:        EXC_BAD_ACCESS (SIGSEGV)
 Exception Codes:       EXC_I386_GPFLT
 Exception Note:        EXC_CORPSE_NOTIFY

 Termination Signal:    Segmentation fault: 11
 Termination Reason:    Namespace SIGNAL, Code 0xb
 Terminating Process:   exc handler [0]

 Thread 0 Crashed:: Dispatch queue: com.apple.main-thread
 0   libc++.1.dylib                      0x00007fff75c4592e
 std::__1::__shared_weak_count::__release_weak() + 4
 1   com.apple.FinderKit                 0x00007fff6578f0c6
 TNodeObserverRegistry::UnregisterNodeObserver(std::__1::shared_ptr<TNodeObserver>)
 + 266
 2   com.apple.FinderKit                 0x00007fff6578eef8
 TNodeObserver::StopObservingSourceNode(TFENode const&,
 NodeNotificationOptions) + 568
 3   com.apple.FinderKit                 0x00007fff657813f9
 TMDQueryAliasNode::~TMDQueryAliasNode() + 99
 4   com.apple.FinderKit                 0x00007fff657815f4
 TMDQueryAliasNode::~TMDQueryAliasNode() + 14
 5   com.apple.FinderKit                 0x00007fff657670c5 void
 CallOnMainThread<void () block_pointer>(void () block_pointer&&) + 29
 6   com.apple.FinderKit                 0x00007fff657670a1
 TCustomNode::ReleaseCustomNodeCallback(OpaqueNodeRef*, void*) + 99
 7   com.apple.desktopservices           0x00007fff642ebe0b TNode::~TNode()
 + 233
 8   com.apple.desktopservices           0x00007fff642ebcca -[FITNode
 dealloc] + 25
 9   libobjc.A.dylib                     0x00007fff7709edb4
 objc_object::sidetable_release(bool) + 266
 10  com.apple.desktopservices           0x00007fff642ebcaa -[FITNode
 releaseUnderMonitor] + 41
 11  com.apple.desktopservices           0x00007fff642cf164
 NodeDisposeNodeRef + 234
 12  com.apple.FinderKit                 0x00007fff6576d74f
 TFENode::~TFENode() + 17
 13  com.apple.FinderKit                 0x00007fff65788967
 std::__1::__vector_base<std::__1::pair<TFENode, TFENode>,
 std::__1::allocator<std::__1::pair<TFENode, TFENode> > >::~__vector_base()
 + 47
 14  libsystem_c.dylib                   0x00007fff77d6aeed
 __cxa_finalize_ranges + 351
 15  libsystem_c.dylib                   0x00007fff77d6b1fe exit + 55
 16  firefox                             0x000000010790ed4b start + 59
 ...
 Thread 0 crashed with X86 Thread State (64-bit):
   rax: 0x0000000125b40310  rbx: 0x0000000125b40300  rcx:
 0x0000000000012068  rdx: 0x0000000000010000
   rdi: 0xe5e5e5e5e5e5e5e5  rsi: 0x0000000000000008  rbp:
 0x00007ffee82f1800  rsp: 0x00007ffee82f1800
    r8: 0x00000000000adb39   r9: 0x000000014bd1f058  r10:
 0x000000012ef18d18  r11: 0x000000012ef18d20
   r12: 0x00007fffad370ee8  r13: 0x0000000165205700  r14:
 0x0000000125b402f0  r15: 0x0000000000000000
   rip: 0x00007fff75c4592e  rfl: 0x0000000000010282  cr2:
 0x00007fff65924192

 Logical CPU:     0
 Error Code:      0x00000000
 Trap Number:     13
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28345>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online