[tbb-bugs] #28051 [Applications/Tor Browser]: Build Orbot into TBA

[Tor Bug Tracker & Wiki]

#28051: Build Orbot into TBA
-------------------------------------------------+-------------------------
 Reporter:  sysrqb                               |          Owner:  sysrqb
     Type:  enhancement                          |         Status:
                                                 |  assigned
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-mobile, tba-a2,                  |  Actual Points:
  TorBrowserTeam201811                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by sysrqb):

 * owner:  tbb-team => sysrqb
 * status:  new => assigned


Comment:

 I have this building and working (mostly).

 It requires modifying Orbot so it is built as a library (producing an AAR,
 Android Archive, instead of an APK). Most of the modifications delete
 application-specific information, such as the `applicationId` (libraries
 aren't allowed an `applicationId` :) ).

 Following the Orbot modifications, building tor-browser now depends on
 Orbot's dependencies, as well - so Orbot's dependencies are now explicitly
 included in tor-browser's Gradle build configuration, too.

 ProGuard needed some modification when building Orbot, too. Its code
 minimization algorithm stripped a unused method, but that method is used
 within tor-browser, so I added an explicit `keep` directive for it.

 Last, tor-browser depends on an older version of the Android support
 libraries than Orbot. Unfortunately the newer versions of the support
 libraries are not backwards-compatible, and Orbot now uses some of the
 newer features, so we can't easily rollback to the older version. Luckily,
 we can compile Orbot against the newer version, and we can compile tor-
 browser against the older version using a Gradle hack.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28051#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online