[tbb-bugs] #26235 [Applications/Tor Browser]: Help menu does not open in Tor Browser nightlies based on ESR60

[Tor Bug Tracker & Wiki]

#26235: Help menu does not open in Tor Browser nightlies based on ESR60
--------------------------------------------+------------------------------
 Reporter:  gk                              |          Owner:  tbb-team
     Type:  defect                          |         Status:  needs_review
 Priority:  Medium                          |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff60-esr,TorBrowserTeam201805R  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------
Changes (by mcs):

 * keywords:  ff60-esr => ff60-esr,TorBrowserTeam201805R
 * status:  new => needs_review


Comment:

 The JS errors occur because Mozilla added code inside
 `browser/base/content/utilityOverlay.js` that assumes that the
 `feedbackPage` and `helpSafeMode` elements are present (see the
 `buildHelpMenu` function). Here is a possible fix:
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug26235-01&id=c63f7d9f65927919bb57011a21e7951d65fd2df3

 Kathy and I confirmed that it makes the JS errors disappear, but we did
 not test the patch on Linux. Maybe someone who has an up-to-date
 ESR60-based Linux build can do that while reviewing this patch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26235#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online