[tbb-bugs] #26073 [Applications/Tor Browser]: patch tor-browser-build.git for Firefox 60 ESR

[Tor Bug Tracker & Wiki]

#26073: patch tor-browser-build.git for Firefox 60 ESR
--------------------------------------------+------------------------------
 Reporter:  arthuredelstein                 |          Owner:  tbb-team
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  TorBrowserTeam201805, ff60-esr  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------
Changes (by gk):

 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:15 sukhbir]:
 > https://github.com/azadi/tor-browser-build-1/tree/bug-26073
 >
 > This branch cherry-picks commits from Arthur's
 [https://github.com/arthuredelstein/tor-browser-build/commits/26073
 branch] but differs by fixing the LLVM signature check (which Arthur just
 merged.) So you can just merge his branch as most of the changes were
 lifted from there (and LLVM signature check was merged) but note that it
 doesn't use `master` on Tor Launcher and Torbutton, while the one above
 (bug-26073) does.

 Some comments while looking a bit on the branch:

 1) We want to use 60.0.1esr for our nightly builds, if that means we need
 to disable the lang pack signature checks for now, then be it so.

 2) https://github.com/azadi/tor-browser-
 build-1/commit/69874135a6550419f95ef39d41a4e3cc5aa5fa02 should be redone.
 There is no need to use the `cat` hack. Instead one can do `./mach
 configure "Here Come All The Configure Args"` and proceed as usual.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26073#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online