[tbb-bugs] #25862 [Applications/Tor Browser]: Clean up wrapper script/CFLAGS and friends mix on Windows

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri May 25 07:28:14 UTC 2018

#25862: Clean up wrapper script/CFLAGS and friends mix on Windows
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  enhancement                          |         Status:
                                                 |  needs_revision
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201805,       |  Actual Points:
  boklm201805                                    |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
Changes (by gk):

 * keywords:  tbb-rbm, TorBrowserTeam201805R, boklm201805 => tbb-rbm,
     TorBrowserTeam201805, boklm201805
 * status:  needs_review => needs_revision


 Looks good to me. One thing we should change is:
 -fstack-protector-all -Wstack-protector --param ssp-buffer-size=4
 in the `CFLAGS` in `rbm.conf`. This line makes not much sense to me as
 there is no need to specify the buffer size if you are adding a canary to
 all functions. Mozilla is using `-fstack-protector-strong` and I believe
 we are doing the same for our Linux builds. Thus, let's go with that one
 for Windows, too?

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25862#comment:8>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list