[tbb-bugs] #26100 [Applications/Tor Browser]: Update Tor Button for ESR 60

[Tor Bug Tracker & Wiki]

#26100: Update Tor Button for ESR 60
-------------------------------------------------+-------------------------
 Reporter:  igt0                                 |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff60-esr, tbb-torbutton,             |  Actual Points:
  TorBrowserTeam201805                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by igt0):

 Replying to [comment:4 arthuredelstein]:
 > Replying to [comment:1 igt0]:
 > > An initial work has been made in the following branch:
 https://github.com/igortoliveira/torbutton/tree/torbutton-esr60
 >
 > Thanks, Igor! I ran into a couple of issues and made some patches to
 merge with your branch.
 >
 > https://github.com/arthuredelstein/torbutton/commits/26100+1
 >
 > The first patch make sure that `nodeDataForCircuit` returns a value. The
 second patch fixes an issue where the browser could not load any remote
 pages -- it would get stuck after I entered the page. I tracked the
 problem down to the pref-loading code added in
 f4ed4ecd5c705e684046ef418f4c519f2c4ce915 and found a fix that seems to
 work.
 >
 > Also regarding f4ed4ecd5c705e684046ef418f4c519f2c4ce915, I have a few
 suggestions.
 >
 >   * I think it would be better to move the pref-loading code into its
 own module, if possible, because it doesn't have any connection to
 logging. Maybe under src/modules/ ?

 Indeed, it should be separated, the trick part is because several
 components need the preferences and they are loaded in the profile-after-
 change notification, in parallel. What do you think besides adding its own
 module, creating a single point of initialization for tor button?
 something similar to the tl-process.js(Tor Launcher)?

 >   * I noticed some other changes in files outside of torbutton-
 logger.js. These seem to be unrelated to the purpose given in the commit
 message, so I am inclined to think we should maybe move these to a
 separate patch if they are necessary.

 +1

 >   * In several places that patch changes code to use
 Services.prefs.getDefaultBranch(null). This seems to be unnecessary when
 `Services.prefs` already works as far as I can tell. So maybe we could
 change these back? It might even be sensible to change all prefs
 operations to use Services.prefs.

 Cool, i will give a try.
 >
 >
 >

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26100#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online