[tbb-bugs] #26059 [Applications/Tor Browser]: Use mar files from the signed directory when generating incremental mars

[Tor Bug Tracker & Wiki]

#26059: Use mar files from the signed directory when generating incremental mars
-------------------------------------+-------------------------------------
     Reporter:  boklm                |      Owner:  tbb-team
         Type:  task                 |     Status:  new
     Priority:  Medium               |  Milestone:
    Component:  Applications/Tor     |    Version:
  Browser                            |   Keywords:  tbb-rbm, boklm201805,
     Severity:  Normal               |  TorBrowserTeam201805
Actual Points:                       |  Parent ID:  #23657
       Points:                       |   Reviewer:
      Sponsor:                       |
-------------------------------------+-------------------------------------
 When generating incremental mar files with `make incrementals-alpha` or
 `make update_responses-release`, we are generating incremental mar files
 in the `{alpha,release}/unsigned/` directory using mar files from the
 previous version in that same directory.

 If the previous version does not exist in that directory, it is downloaded
 and the incrementals are generated correctly, using the code-signed osx
 version. However, if the previous versions was built on this machine, the
 unsigned directory will contain an unsigned build for the previous
 version, which will be used to generate the incrementals.

 Instead, the `{alpha,release}/signed/` directory should be used as the
 input for the previous version.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26059>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online