[tbb-bugs] #25980 [Applications/Tor Browser]: Orfox bustage on tor-browser-52.7.3esr-8.0-1

Tor Bug Tracker & Wiki blackhole at torproject.org
Tue May 1 00:41:34 UTC 2018

#25980: Orfox bustage on tor-browser-52.7.3esr-8.0-1
 Reporter:  sysrqb                    |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_review
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-mobile                |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
Changes (by sysrqb):

 * status:  new => needs_review


 Okay, easy fix.

 On Android, the NDK (from LLVM) defines `__libc_feof(FILE*)` as a wrapper
 around `feof(FILE*)`. Mozilla redefined `feof` as `feof(hnjFile*)`, this
 caused a type mismatch because `__libc_feof(FILE* f)` then called
 `feof(f)` but `f` was the wrong type (FILE*, instead of hnjFile*). We can
 redefine `__libc_feof` the same way Mozilla redefined `feof` - using a C++

 The guards around the #define aren't strictly necessary, but I didn't want
 to introduce unnecessary changes on other platforms. We can delete them if
 that's preferred.

 Branch bug25980

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25980#comment:6>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list