[tbb-bugs] #25659 [Applications/Tor Browser]: Race-condition loading add-ons in Orfox

[Tor Bug Tracker & Wiki]

#25659: Race-condition loading add-ons in Orfox
--------------------------------------+--------------------------
 Reporter:  sysrqb                    |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-mobile                |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by sysrqb):

 hm. I built a new apk with `extensions.logging.enabled = true` so we get
 logging on first-run.

 {{{
 I/Gecko   (28133): 1522192347000        addons.xpi      DEBUG   Addon
 https-everywhere at eff.org will be installed as a packed xpi
 I/Gecko   (28133): 1522192347000        addons.xpi      DEBUG   Addon tor-
 browser-settings at torproject.org will be installed as a packed xpi
 I/Gecko   (28133): 1522192347100        addons.xpi      DEBUG   Addon
 {73a6fe31-595d-460b-a920-fcc0f8843232} will be installed as a packed xpi
 I/Gecko   (28133): 1522192347100        addons.xpi      DEBUG   Staged
 install of https-everywhere at eff.org from
 file:///data/data/info.guardianproject.orfox/distribution/extensions
 /https-everywhere at eff.org.xpi ready; waiting for restart.
 }}}

 `Staged install of https-everywhere at eff.org [...] ready; waiting for
 restart.`

 This doesn't explain why it isn't loaded after restarting the app, but
 this explains why it isn't loaded on first-run. With this install, it is
 loaded after restarting the app.

 {{{
 I/Gecko   (28760): 1522193195700        addons.xpi      DEBUG   Found
 updated metadata for https-everywhere at eff.org in app-profile
 I/Gecko   (28760): 1522193195700        addons.xpi      DEBUG   Processing
 install of https-everywhere at eff.org in app-profile
 }}}

 I wonder what happens if I clear the app's cache/data and start fresh, but
 toggle extension.logging.enabled so it is enabled on first-run but
 disabled on second-run. Does the logging make a difference?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25659#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online