[tbb-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository

[Tor Bug Tracker & Wiki]

#25013: Move TorButton code to the tor browser repository
--------------------------------------+--------------------------------
 Reporter:  igt0                      |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201803      |  Actual Points:
Parent ID:  #10760                    |         Points:
 Reviewer:  gk, sysrqb, mcs,          |        Sponsor:
--------------------------------------+--------------------------------

Comment (by igt0):

 sysrqb wrote about the downsides of trying to build the .xpi outside the
 tor-browser repo:

 https://trac.torproject.org/projects/tor/ticket/25260#comment:11

 I also updated the code fixing arthur's comments:

 ** bug 25013: Add Gecko build system infrastructure into tor button**
 https://github.com/igortoliveira/torbutton/commit/86fc5398a573a43620ec3023d92207ce63def278

 **  bug 25013: Migrate general.useragent.locale to intl.locale.requested
 **
 https://github.com/igortoliveira/torbutton/commit/b8443a3e75ed59283bdd52b875625534be1b96b7

 **  bug 25013: Update deprecated JS code **
 https://github.com/igortoliveira/torbutton/commit/1b51d8afc0be10bf363b5387dbbfcd75ee021161

 **  bug 25013: Update XPCOM calls after changes in the interfaces **
 https://github.com/igortoliveira/torbutton/commit/c68eea2c04d24e3cb47f707620365da1dbe8c7b2

 **  bug 25013: Initialize startup.homepage in the startup-observer
 component **
 https://github.com/igortoliveira/torbutton/commit/cfef8182c6a5b4a294da98f0a5e71d80ce6f6472


 Replying to [comment:25 gk]:
 > I agree with Arthur (I have not looked at the Github commits but meant
 to +1 the bundling of the .xpi in the Torbutton repo and then getting that
 copied into the browser part later on.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25013#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online