[tbb-bugs] #23561 [Applications/Tor Browser]: Fix nsis builds for Windows 64

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Jun 18 14:36:36 UTC 2018

#23561: Fix nsis builds for Windows 64
 Reporter:  boklm                          |          Owner:  tbb-team
     Type:  task                           |         Status:  needs_review
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201806  |  Actual Points:
Parent ID:                                 |         Points:
 Reviewer:                                 |        Sponsor:
Changes (by sukhbir):

 * status:  needs_revision => needs_review


 Replying to [comment:24 boklm]:
 > Replying to [comment:23 boklm]:
 > > In `projects/nsis/build` there is a line `[% IF c("var/windows") %]`,
 but this `IF` is always true as we only build `nsis` for Windows. So I
 think the `IF` can be removed.
 > In `projects/nsis/config` the line `enable: '[% c("var/windows") %]'`
 can also be removed.

 Thanks, I removed the `c("var/windows")` guard for zlib in both the build
 and the config files. (Same branch for review.)


Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23561#comment:25>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list