[tbb-bugs] #26203 [Applications/Tor Browser]: Adapt tor-browser-build firefox and tor-browser project for ESR 60 Windows build

[Tor Bug Tracker & Wiki]

#26203: Adapt tor-browser-build firefox and tor-browser project for ESR 60 Windows
build
---------------------------------------------+-----------------------------
 Reporter:  gk                               |          Owner:  tbb-team
     Type:  task                             |         Status:
                                             |  needs_review
 Priority:  Very High                        |      Milestone:
Component:  Applications/Tor Browser         |        Version:
 Severity:  Normal                           |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201806R  |  Actual Points:
Parent ID:                                   |         Points:
 Reviewer:                                   |        Sponsor:
---------------------------------------------+-----------------------------

Comment (by sukhbir):

 Replying to [comment:11 boklm]:
 > Replying to [comment:10 sukhbir]:
 > > Replying to [comment:9 gk]:
 > > > sukhbir: Why do we need `pre_pkginst: dpkg --add-architecture i386`
 for the 64bit case? Compiling without it works for me.
 > >
 > > Without adding it, I was getting something like `it looks like
 multiarch needs to be enabled.` Also, I based this on
 https://wiki.debian.org/Wine, which says:
 > >
 > > {{{
 > > On 64-bit systems you should enable a 32-bit architecture for
 multiarch. This is needed for running 32-bit Windows applications (many
 modern apps are still 32-bit), but also for large parts of the Windows
 subsystem itself. If in doubt, you do need it!
 > > }}}
 > >
 > > But maybe `Wine64` is all we need if it works without that.
 >
 > Isn't that the error that you were having when you were trying to use
 the 32bit `d3dcompiler_47.dll`?
 > When using the 64bit version of `d3dcompiler_47.dll` I don't think we
 need the 32bit version of wine.

 OK, if that's the case and it does compile without it, we should remove
 it. Should I update the patch?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26203#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online