[tbb-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Jul 26 15:15:51 UTC 2018

#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
 Reporter:  sysrqb                            |          Owner:  tbb-team
     Type:  task                              |         Status:
                                              |  needs_revision
 Priority:  Very High                         |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807  |  Actual Points:
Parent ID:  #26531                            |         Points:
 Reviewer:                                    |        Sponsor:
Changes (by gk):

 * status:  needs_review => needs_revision


 Okay, we are getting close, just the following comments/remarks are left:

 commit 0b932f895e3b2866161048a6007e61e257dc395b -- not okay

 There is no need for a `--enable-install-strip` as we already strip
 everything with `--enable-strip`.

 commit 408e63083f15d59c98fee619a277dfe123429d8c -- not okay

 we should follow the Android version as used in the resist fingerprinting
 mode, see:


 I.e. "Android 4.1.0" > "Android 6.0" which is way more popuplar than 4.1.0
 as well.

 commit 7bc689d797439d6394853e421f71eda5d7d1631a -- not okay

 +import android.content.IntentFilter; <- seems to be something not used
 (probably part of the NetCipher upgrade on the previous branch?)

 `checkStartOrbot()` came before `processTabQueue()` before (and the if-
 clause around `!mHasResumed` got deleted). Doesn't the order matter here?
 (I don't know just for double-checking)

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26401#comment:36>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list