[tbb-bugs] #25485 [Applications/Tor Browser]: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found (required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)

[Tor Bug Tracker & Wiki]

#25485: Browser/TorBrowser/Tor/libstdc++.so.6: version `CXXABI_1.3.11' not found
(required by /usr/lib/x86_64-linux-gnu/libmirclient.so.9)
--------------------------------------------+------------------------------
 Reporter:  cypherpunks                     |          Owner:  tbb-team
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201807  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:
--------------------------------------------+------------------------------
Changes (by sukhbir):

 * status:  reopened => needs_revision


Comment:

 For review:

 https://github.com/azadi/tor-browser-build-1/tree/bug-25485

 This is tested on Ubuntu 17.04 (`gcc 7`; newer) as well as Ubuntu 16.04
 (`gcc 5.3.1`; older). To initiate the ABI check, we compare the installed
 `gcc` version with the bundled Tor Browser version `6.4.0`. If the
 installed version is more recent, we remove the bundled `libstdc++.so.6`
 from `Browser/TorBrowser/Tor`, which removes it from `LD_LIBRARY_PATH`.

 I am guessing this should suffice, or should we follow the symlink for
 libstdc++.so.6 and then compare the `CXXABI`, like for Ubuntu 17.04:

 {{{
 $ strings /usr/lib/x86_64-linux-gnu/libstdc++.so.6.0.24  | grep
 CXXABI_[[:digit:]] | sort -Vr | head -1
 CXXABI_1.3.11
 }}}

 and then compare it with the Tor Browser version:

 {{{
 $ strings Browser/TorBrowser/Tor/libstdc++.so.6  | grep CXXABI_[[:digit:]]
 | sort -Vr | head -1
 CXXABI_1.3.10
 }}}

 which tells us the same thing and instead of comparing the version
 strings, we can compare this but I thought the `gcc` version is more
 direct.

 (As indicated in comment:14, we should consider using `rpath` as discussed
 in #13373 but I am not focusing on that for now.)

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25485#comment:15>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online