[tbb-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Jul 18 14:25:12 UTC 2018

#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
 Reporter:  sysrqb                             |          Owner:  tbb-team
     Type:  task                               |         Status:
                                               |  needs_review
 Priority:  Very High                          |      Milestone:
Component:  Applications/Tor Browser           |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807R  |  Actual Points:
Parent ID:  #26531                             |         Points:
 Reviewer:                                     |        Sponsor:

Comment (by gk):


 commit 952f0ae78cc17f66624f3c634d831ff0aedc9692 -- not okay

 It seems we don't need
 +import java.net.Proxy;
 +import java.net.InetSocketAddress;

 and regarding

 +import ch.boye.httpclientandroidlib.HttpHost;
 +import ch.boye.httpclientandroidlib.conn.params.ConnRoutePNames;

 The first gets imported twice with that code snippet and could you move
 the second one to
 where it fits into the ch.boye.httpclientandroidlib.conn.* area?

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26401#comment:26>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list