[tbb-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA
Tor Bug Tracker & Wiki
blackhole at torproject.org
Wed Jul 18 00:54:17 UTC 2018
#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
-----------------------------------------------+---------------------------
Reporter: sysrqb | Owner: tbb-team
Type: task | Status:
| needs_review
Priority: Very High | Milestone:
Component: Applications/Tor Browser | Version:
Severity: Normal | Resolution:
Keywords: tbb-mobile, TorBrowserTeam201807R | Actual Points:
Parent ID: #26531 | Points:
Reviewer: | Sponsor:
-----------------------------------------------+---------------------------
Comment (by sysrqb):
Replying to [comment:19 gk]:
> commit a2c4e6217da42219327206508015ee24846907c4 -- probably okay (Any
reason the Facebook bg color (#ffecf0f3) did not get adjusted as done in
the original patch?)
No, I applied the patch manually because there were many conflict. I think
I chose keeping the Fennec background color instead of changing it to
#ffecf0f3 because #3B5998 is the normal "Facebook Blue".
>
> commit 91eeee498b6733075d1de69d9f3568bfbffb5f05 -- not okay
>
> I assume the resistfingerprinting related UA is not being used by Java
code automatically? If so, then we should hardcode that one and not a
custom one.
Okay, I'll change the UA strings so they are hard coded instead of
concatenating static values.
>
> commit 14cefdc4bd90083e22ac263954a857d254b346a9 -- not okay
>
> Indentation of the if-clauses
>
Ack.
--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26401#comment:22>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online
More information about the tbb-bugs
mailing list