[tbb-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA

[Tor Bug Tracker & Wiki]

#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
-----------------------------------------------+---------------------------
 Reporter:  sysrqb                             |          Owner:  tbb-team
     Type:  task                               |         Status:
                                               |  needs_review
 Priority:  Very High                          |      Milestone:
Component:  Applications/Tor Browser           |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807R  |  Actual Points:
Parent ID:  #26531                             |         Points:
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by gk):

 commit 21149e7a423d1f88866e5781e521021a08fca126 -- not okay

 Indentation of code in the else-clauses is missing. Are we good with all
 the other account manager related things that Orfox patched but this patch
 omits?

 commit db3c54ef05e71234a009bdc1abdbf9b80135cb0a -- ???

 That one is hard for me to review. Is that a new NetCipher version
 included? If so, what's the new one and what was the old one, used for
 ESR52?

 Do we really want to have mobile/android/orfox? What happened to
 {{{
 +  <string
 name="no_space_to_start_error">&no_space_to_start_error;</string>
 +  <string name="error_loading_file">&error_loading_file;</string>
 }}}
 ?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26401#comment:18>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online