[tbb-bugs] #26401 [Applications/Tor Browser]: Rebase Orfox patches onto Tor Browser 8.0 for TBA

[Tor Bug Tracker & Wiki]

#26401: Rebase Orfox patches onto Tor Browser 8.0 for TBA
-----------------------------------------------+---------------------------
 Reporter:  sysrqb                             |          Owner:  tbb-team
     Type:  task                               |         Status:
                                               |  needs_review
 Priority:  Very High                          |      Milestone:
Component:  Applications/Tor Browser           |        Version:
 Severity:  Normal                             |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201807R  |  Actual Points:
Parent ID:  #26531                             |         Points:
 Reviewer:                                     |        Sponsor:
-----------------------------------------------+---------------------------

Comment (by sysrqb):

 Replying to [comment:9 igt0]:
 >
 > ''952f0ae78cc1 Orfox: Centralized proxy applied to CrashReporter,
 SuggestClient, Distribution, AbstractCommunicator and BaseResources.''
 > Can we use the {{{network.proxy.*}}} instead of hardcoding the proxy
 configuration in the java file?

 Unfortunately, no, not easily. This is within GeckoView, and gradle builds
 it this library early in the build process. Accessing preferences is
 handled by
 `mobile/android/base/java/org/mozilla/gecko/preferences/GeckoPreferences.java`,
 and this is built during the Fennec build process. Basically,
 GeckoPreferences doesn't exist when GeckoView is compiled.

 I considered some solutions/workarounds for this, but I decided hardcoding
 these values is an easy solution and it is probably acceptable for the
 first alpha. When we integrate Tor into the app we will need a
 new/different solution anyway.

 Do you think there is another easy way we can use the prefs?

 >
 > ''44c65b7904d8 Orfox: add BroadcastReceiver to receive Tor status from
 Orbot''
 > Should we initialize the {{{sTorStatus}}}?

 Yes!

 >
 > ''db3c54ef05e7 Orfox: NetCipher enabled, checks if orbot is installed''
 > Is {{{import android.os.Looper}}} needed?

 No, I'll delete it.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26401#comment:13>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online