[tbb-bugs] #24421 [Applications/Tor Browser]: "Temporarily allow all this page" and uploads get inherited when New Identity is chosen.

[Tor Bug Tracker & Wiki]

#24421: "Temporarily allow all this page" and uploads get inherited when New
Identity is chosen.
----------------------------------------------+--------------------------
 Reporter:  cypherpunks                       |          Owner:  tbb-team
     Type:  defect                            |         Status:  new
 Priority:  High                              |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Major                             |     Resolution:
 Keywords:  tbb-newnym, TorBrowserTeam201801  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+--------------------------

Comment (by mcs):

 Replying to [comment:11 gk]:
 > mcs, brade do you have some cycles to look at this bug? I probably
 won't, alas. :(

 Kathy and I spent some time debugging this today, but we did not find the
 root cause. Due to other committments, we may not have much time to work
 on this until next week, so I am posting what we learned so far here:
 * Running with e10s disabled (MOZ_FORCE_DISABLE_E10S=1) avoids the
 problem.
 * I am not convinced it is the cause of this bug because NoScript appears
 to catch the errors and ignore them, but when running with a debug build
 when e10s is enabled, several messages like the following are emitted
 right after the call to `nsSvc.eraseTemp()` (called from Torbutton's
 torbutton_do_new_identity() function):
 {{{
 [Child 23233] ###!!! ASSERTION: ENSURE_MAIN_PROCESS failed. Cannot
 SetCharPref from content process: temp: 'Error', file /.../dev/tor/tor-
 browser/modules/libpref/nsPrefBranch.cpp, line 195
 }}}
 * I don't know anything about the NoScript internals, but when this bug
 occurs it seems that `eraseTemp()` (inside NoScript's Main.js) is called
 twice: once directly by Torbutton and once in response to a `browser
 :purge-session-history` observer notification. But I don't know if the
 fact that `eraseTemp()` is called twice is causing a problem.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24421#comment:12>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online