[tbb-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Feb 28 20:52:31 UTC 2018

#25013: Move TorButton code to the tor browser repository
 Reporter:  igt0                      |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201802      |  Actual Points:
Parent ID:  #24855                    |         Points:
 Reviewer:  gk, sysrqb, mcs,          |        Sponsor:
Changes (by igt0):

 * status:  needs_revision => needs_review


 I followed the same approach in the #25260, torbutton will work as a
 feature extension, so we still need to change the browser adding it as a
 subdirectory(git submodule?).
 The changes in the tor button are related to the build system and making
 it work with the mozilla central code base(few things changed and others
 are deprecated).

  **bug 25013: Add Gecko build system infrastructure into tor button**

  **bug 25013: Migrate general.useragent.locale to intl.locale.requested **

  **bug 25013: Update deprecated JS code**

  **bug 25013: Update XPCOM calls after changes in the interfaces**

 Replying to [comment:19 gk]:
 > FWIW: I can see us copying over files from the Torbutton repo or just
 package up an .xpi and put the extracted files into tor-browser.git before
 we tag (and use the machinery developed in some of the patches above). I
 just think that step 1 of the migration should not contain getting rid of
 the Torbutton repo. We should do this once we integrate the components we
 need tighter into the browser. I guess this would be a thing, at some
 point, for step 3 in Arthur's staged approach.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25013#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list