[tbb-bugs] #23136 [Applications/Tor Launcher]: moat integration (fetch bridges for the user)

[Tor Bug Tracker & Wiki]

#23136: moat integration (fetch bridges for the user)
--------------------------------------------+------------------------------
 Reporter:  mcs                             |          Owner:  brade
     Type:  defect                          |         Status:  needs_review
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Launcher       |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  TorBrowserTeam201802R, ux-team  |  Actual Points:
Parent ID:  #24689                          |         Points:
 Reviewer:                                  |        Sponsor:  Sponsor4
--------------------------------------------+------------------------------

Comment (by brade):

 Replying to [comment:62 gk]:
 > ...
 > 4) `let proxySettings;` as we are using it later on
 > even if no proxy settings got specified should we initialize it somehow,
 say to `undefined`?

 It will be initialized to `undefined` because that is how JS works (and we
 rely on that fact in many places).

 > 5)
 > ...
 > Why do we have the `showBridgeDBBridges()` call here if we are not using
 BridgeDB bridges
 > (i.e. there aren't any to begin with)?

 The call to `showBridgeDBBridges();` is there because we want to remove
 any old bridge lines from the UI (it clears them if gBridgeDBBridges is
 undefined or empty). But to address your item 3) in comment:49 we will be
 removing this block of code.

 > 7)
 >
 > It might not matter much but is socks4 really the thing we should test
 first
 > (meaning the protocol we expect to get used in the majority of cases)
 when
 > creating the proxy URL?

 We just followed the order that is presented in the dropdown menu within
 the UI.

 > 9)
 >
 > Do we need a spec update or an updated link to the spec you gave in `tl-
 bridgedb.jsm`? 'type': 'moat client supported transports' got changed
 'type':'client-transports' etc.
 > So, https://github.com/isislovecruft/bridgedb/tree/fix/22871#requesting-
 bridges does
 > not have latest version it seems?

 Good catch. A better URL for the spec (which we will put in the source
 code) is:
 https://github.com/isislovecruft/bridgedb/#accessing-the-moat-interface

 We will also fix the other (minor) items that I did not mention above.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23136#comment:65>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online