[tbb-bugs] #25013 [Applications/Tor Browser]: Move TorButton code to the tor browser repository

Tor Bug Tracker & Wiki blackhole at torproject.org
Thu Feb 1 20:57:07 UTC 2018


#25013: Move TorButton code to the tor browser repository
--------------------------------------+--------------------------------
 Reporter:  igt0                      |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201802      |  Actual Points:
Parent ID:  #24855                    |         Points:
 Reviewer:  gk, sysrqb, mcs,          |        Sponsor:
--------------------------------------+--------------------------------

Comment (by gk):

 Replying to [comment:9 gk]:
 > Okay, I just compiled bundles with all the patches.
 >
 > One thing for the `tor-browser-build` one: Could you add the bug number
 in front of your commit message like "Bug 25013:"?
 >
 > For the browser patches:
 >
 > 1) I don't see the Torbutton icon on the toolbar button.
 > 2) The arrow warning me that my version out-of-date is not visible
 either.

 Those two might actually not be your fault. It turns out that the `patch`
 does not like the `git` binary diffs are seems to ignore the images in the
 Linux case and breaks the Windows builds. Let me try to test your patches
 differently tomorrow.

 > That's on a 64bit Linux box.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25013#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tbb-bugs mailing list