[tbb-bugs] #28830 [Applications/Tor Browser]: Clean up tor-browser-build build scripts/config files

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Dec 12 09:22:51 UTC 2018


#28830: Clean up tor-browser-build build scripts/config files
------------------------------------------+----------------------
     Reporter:  gk                        |      Owner:  tbb-team
         Type:  task                      |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:  tbb-rbm
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+----------------------
 We should go over the projects we have in `tor-browser-build` and clean up
 build scripts and config files if needed.

 Areas we could/should cover:

 1) We sometimes have several platform related blocks in one build script
 which could be confusing. Can we merge those (or some of them) while still
 keeping the overall flow of the script logic?

 2) Duplicating platform-specific and !platform-specific commands, e.g. `cd
 $distdir` in
 {{{
 [% IF c("var/osx") %]
   LIBEVENT_FILE=`basename $libeventdir/lib/libevent-*.dylib`
   cd $distdir
   cp bin/tor $TORBINDIR/
   cd $TORBINDIR/
   x86_64-apple-darwin11-install_name_tool -change
 $libeventdir/lib/$LIBEVENT_FILE @executable_path/$LIBEVENT_FILE tor
 [% END %]

 cd $distdir
 }}}

 3)...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/28830>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tbb-bugs mailing list