[tbb-bugs] #26520 [Applications/Tor Browser]: NoScript is broken with TOR_SKIP_LAUNCH=1 in ESR 60-based Tor Browser

Tor Bug Tracker & Wiki blackhole at torproject.org
Sun Aug 19 13:02:54 UTC 2018

#26520: NoScript is broken with TOR_SKIP_LAUNCH=1 in ESR 60-based Tor Browser
 Reporter:  gk                              |          Owner:  tbb-team
     Type:  defect                          |         Status:
                                            |  needs_revision
 Priority:  Very High                       |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff60-esr, TorBrowserTeam201808  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:

Comment (by rustybird):

 Replying to [comment:11 rustybird]:
 > Maybe there's a second race condition somewhere, e.g. NoScript ignoring
 a message delivered successfully but very early?

 Looks like my debug-retry.diff sends the settings so early that NoScript
 will clobber them during its own startup. I've attached two new patches
 that ensure the message is sent at the right time, neither too soon nor
 too late:

 - noscript-NoScript.started.diff, if applied to NoScript (`unix2dos <
 noscript-NoScript.started.diff | patch --binary -p2` inside an unpacked
 NoScript extension directory) makes it broadcast a `NoScript.started` type
 message after it has initialized. If someone wants to test it, don't
 forget to disable signature verification for the modified NoScript
 extension, e.g. by flipping the `xpinstall.signatures.required` pref to
 - torbutton-NoScript.started.diff, if applied to Torbutton (on top of
 arthuredelstein's second patch), waits for exactly that message.


Ticket URL: <https://trac.torproject.org/projects/tor/ticket/26520#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list