[tbb-bugs] #25696 [Applications/Tor Browser]: Design of alpha onboarding for Tor Browser for Android

[Tor Bug Tracker & Wiki]

#25696: Design of alpha onboarding for Tor Browser for Android
-------------------------------------------------+-------------------------
 Reporter:  isabela                              |          Owner:
                                                 |  antonela
     Type:  defect                               |         Status:
                                                 |  needs_revision
 Priority:  Very High                            |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ux-team, tbb-mobile,                 |  Actual Points:
  TorBrowserTeam201808R                          |
Parent ID:  #26531                               |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor8
-------------------------------------------------+-------------------------
Changes (by sysrqb):

 * status:  needs_review => needs_revision


Comment:

 Do we need two public constructors in`FirstrunTorPanelConfig`? I only see
 one place where the constructor is used (in `SimplePanelConfigs`) and they
 all call the constructor with five arguments.

 ----

 `firstrun_privacy_title` and some of the other *_title strings should not
 have "Title" in the string. They should say "Privacy", "Tor Network", etc.
 (instead of "Privacy Title", "Tor Network Title").

 ----

 We'll want the darker Private tab theme, but that isn't critical for this
 right now.

 ----

 The first two panels use the Firefox icon, we should change that.

 ----

 For some reason the escaped-apostrophe in `firstrun_tornetwork_message`
 ("there\’s no single point of failure") isn't rendering on my device. It
 shows `theres no single point of failure`.

 ----

 `firstrun_tips_message` is missing a period at the end.

 ----

 Can you change `R.id.firstrun_link` in `FirstrunLastPanel` so it uses a
 resource that says "Close"?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25696#comment:27>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online