[tbb-bugs] #24465 [Applications/Tor Browser]: Snowflake broken if no libatomic on host

[Tor Bug Tracker & Wiki]

#24465: Snowflake broken if no libatomic on host
-------------------------------------------------+-------------------------
 Reporter:  isabela                              |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  snowflake, tbb-rbm,                  |  Actual Points:
  TorBrowserTeam201808                           |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:18 sukhbir]:
 > For review:
 >
 > https://github.com/azadi/tor-browser-build-1/tree/bug-24465

 IIRC this was a 64but-only problem but you are copying the lib for 32bit
 as well which seems to be not needed (if I got the history of this bug
 right).

 > Note that this simply copies the library from `gcc/libs`. Perhaps we can
 do something similar for #25485, where we first try to run `snowflake-
 client` and if it fails, then only we add it `libatomic.so` to
 `LD_LIBRARY_PATH`. Is that preferred?

 We could do that. But we eventually want to get rid of `LD_LIBRARY_PATH` I
 think and not add another workaround to this workaround if possible. So, I
 wonder if this bug would be a good start to look into compiling with a
 relative `-rpath`. See: #13373 and #13359 where I did some initial work
 some years ago.

 > I reproduced and tested this on Lubuntu 17.10.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24465#comment:19>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online