[tbb-bugs] #24056 [Applications/Tor Browser]: UI locale is detectable by button width

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Aug 13 21:08:01 UTC 2018

#24056: UI locale is detectable by button width
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  needs_review
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-fingerprinting,                  |  Actual Points:
  TorBrowserTeam201808R                          |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:

Comment (by pospeselr):

 Looking at the code, there doesn't *seem* to be any reason why
 gPropertiesFile can't be:
 static const char* gPropertiesFile[nsContentUtils::PropertiesFile[COUNT]

 The CreateBundle method each of those strings is passed to expects a const
 char* with no hard-coded expectation of length.  It's static so the symbol
 can't be resolved outside this cpp.  Also, fwiw the new max length string
 in that array is 75, not 78 (including null-terminator).

 Why is the setting to enable 2 rather than 1?

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24056#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list