[tbb-bugs] #25980 [Applications/Tor Browser]: Orfox bustage on tor-browser-52.7.3esr-8.0-1

[Tor Bug Tracker & Wiki]

#25980: Orfox bustage on tor-browser-52.7.3esr-8.0-1
--------------------------------------+--------------------------
 Reporter:  sysrqb                    |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-mobile                |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by sysrqb):

 Right, so this patch redefines `feof()` and changes the function signature
 (`feof(FILE*)` -> `feof(hnjFile*)`), and it seems there isn't a conversion
 between FILE and hnjFile. Fun.

 {{{
 diff --git a/intl/hyphenation/glue/hnjalloc.h
 b/intl/hyphenation/glue/hnjalloc.h
 index fec3a4b..5cee1be1 100644
 --- a/intl/hyphenation/glue/hnjalloc.h
 +++ b/intl/hyphenation/glue/hnjalloc.h
 @@ -31,6 +31,8 @@
  #define fopen(path,mode)      hnjFopen(path,mode)
  #define fclose(file)          hnjFclose(file)
  #define fgets(buf,count,file) hnjFgets(buf,count,file)
 +#define feof(file)            hnjFeof(file)
 +#define fgetc(file)           hnjFgetc(file)

  typedef struct hnjFile_ hnjFile;

 @@ -44,6 +46,10 @@ int hnjFclose(hnjFile* f);

  char* hnjFgets(char* s, int n, hnjFile* f);

 +int hnjFeof(hnjFile* f);
 +
 +int hnjFgetc(hnjFile* f);
 +
  #ifdef __cplusplus
  }
  #endif
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25980#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online