[tbb-bugs] #25862 [Applications/Tor Browser]: Clean up wrapper script/CFLAGS and friends mix on Windows

[Tor Bug Tracker & Wiki]

#25862: Clean up wrapper script/CFLAGS and friends mix on Windows
--------------------------------------+--------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  enhancement               |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  tbb-rbm                   |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Old description:

> Our mix of wrapper scripts and usage of CFLAGS/LDFLAGS when compiling on
> Windows has grown over the years to a point where it gets confusing. We
> should get back to sanity here.
>
> We needed the wrapper scripts to pass down all required flags to the
> depths of the Firefox build system, but meanwhile those scripts are used
> almost everywhere and `CFLAGS`/`LDFLAGS` additionally sometimes.
>
> One option boklm brought up would be to use the `CFLAGS`/`LDFLAGS`
> defined in rbm.conf and enable those script only during Firefox's build.
>
> Another just get rid of those wrapper script and fix the missing pieces
> in Firefox if those are still there.
>
> At any rate, we should document where we need them in the first place to
> avoid lengthy digging in case someone is wondering in the future or now,
> while looking at our build scripts.

New description:

 Our mix of wrapper scripts and usage of CFLAGS/LDFLAGS when compiling on
 Windows has grown over the years to a point where it gets confusing. We
 should get back to sanity here.

 We needed the wrapper scripts to pass down all required flags to the
 depths of the Firefox build system, but meanwhile those scripts are used
 almost everywhere and `CFLAGS`/`LDFLAGS` additionally sometimes.

 One option boklm brought up would be to use the `CFLAGS`/`LDFLAGS` defined
 in rbm.conf and enable those script only during Firefox's build.

 Another just get rid of those wrapper scripts and fix the missing pieces
 in Firefox if those are still there.

 At any rate, we should document where we need them in the first place to
 avoid lengthy digging in case someone is wondering in the future or now,
 while looking at our build scripts.

--

Comment (by gk):

 FWIW, I came up with this ticket because I hit link failures when building
 the rust std lib for Windows (while working on #25849). It turns out that
 the wrappers compile libbacktrace and jemalloc with stack protections
 support, but the linker when building the std lib is not regarding `-lssp`
 (see linker arg construction in https://github.com/rust-
 lang/rust/blob/1.25.0/src/librustc_back/target/windows_base.rs).

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25862#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online