[tbb-bugs] #25859 [Applications/Tor Browser]: Clean up zlib's build script

[Tor Bug Tracker & Wiki]

#25859: Clean up zlib's build script
------------------------------------------+----------------------
     Reporter:  gk                        |      Owner:  tbb-team
         Type:  enhancement               |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:  tbb-rbm
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+----------------------
 We should clean up the compile and link flags zlib build script:

 1) `CFLAGS` and `LDFLAGS` seem to be unused, rather `LOC` is taken to
 define those.
 2) Given 1) we could just assign the relevant flags to `LOC` and omit
 `CFLAGS` and `LDFLAGS` entirely AND we can omit spelling `LOC` out twice
 (once in the `make` command and once in the `make install` command).
 3) While we are at it, just doing a `make install` might be enough.
 4) No need to hard-code `-j4`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25859>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online