[tbb-bugs] #25834 [Applications/Tor Browser]: Use compiler dependent spec files for mingw-w64

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Apr 18 09:20:22 UTC 2018


#25834: Use compiler dependent spec files for mingw-w64
------------------------------------------+-------------------------------
     Reporter:  gk                        |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:  tbb-rbm, ff60-esr
Actual Points:                            |  Parent ID:  #24631
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+-------------------------------
 Back then in the gitian days when cross-compiling for Windows we used two
 `i686-w64-mingw32-g++ -dumpspecs > ~/build/msvcr100.spec` commands to
 extract the relevant spec file for making sure we use `msvcr100` instead
 of `msvcrt`: one in the utils descriptor when building the compiler and
 one in the firefox descriptor when building the browser.

 When moving to rbm those two commands got squashed into one and the
 resulting `msvcr100.spec` gets used for both the compiler and the browser.
 However, a crucial difference between both projects is that the GCC
 version used is not matching. Comparing the resulting spec file of the GCC
 used for the compiler (4.9.2) and the one used for the browser (6.4.0)
 shows a bunch of differences.

 The system feels already quite fragile, so we should not bet on not seeing
 subtle bugs due to the used spec file in the browser not matching the
 respective compiler version. Rather, we should go back to the old behavior
 where we use the spec file bound to the compiler version used.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25834>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tbb-bugs mailing list