[tbb-bugs] #25603 [Applications/Tor Browser]: Update Orfox HTTPS-E Add-on

[Tor Bug Tracker & Wiki]

#25603: Update Orfox HTTPS-E Add-on
----------------------------------------------+--------------------------
 Reporter:  sysrqb                            |          Owner:  sysrqb
     Type:  enhancement                       |         Status:  assigned
 Priority:  Very High                         |      Milestone:
Component:  Applications/Tor Browser          |        Version:
 Severity:  Normal                            |     Resolution:
 Keywords:  tbb-mobile, TorBrowserTeam201804  |  Actual Points:
Parent ID:                                    |         Points:
 Reviewer:                                    |        Sponsor:
----------------------------------------------+--------------------------
Changes (by sysrqb):

 * owner:  tbb-team => sysrqb
 * status:  new => assigned


Comment:

 Unfortunately this is not working as expected.

 In addition to #25659, during testing I am seeing https-everywhere
 successfully load, but then it doesn't rewrite any URLs. I also tested
 using an older version of Orfox (based on 52.2.0), and it bundles https-
 everywhere 5.2.20 (tagged on 05 Jul, 2017). This combination of https-
 everywhere+Orfox works as expected, and the URLs are rewritten. If I leave
 Orfox open for some time, https-everywhere automatically updates to
 version 2018.4.11 (webextension). After restarting the app, I see the add-
 on loads, but it doesn't perform any URL rewrites. I see some messages in
 the log about an error processing the add-on's manifest, but it seems like
 the extension is loaded successfully.

 {{{
 I/Gecko   (24006): 1523904137200        addons.xpi      DEBUG
 getModTime: Recursive scan of https-everywhere-eff at eff.org
 I/Gecko   (24006): 1523904137200        DeferredSave.extensions.json
 DEBUG   Starting timer
 I/Gecko   (24006): 1523904137500        DeferredSave.extensions.json
 DEBUG   Starting write
 I/Gecko   (24006): 1523904137700        addons.webextension.https-
 everywhere-eff at eff.org        WARN    Loading extension 'https-everywhere-
 eff at eff.org': Reading manifest: Error processing permissions.3: Unknown
 permission "tabs"
 I/Gecko   (24006): 1523904137700        addons.webextension.https-
 everywhere-eff at eff.org        WARN    Loading extension 'https-everywhere-
 eff at eff.org': Reading manifest: Error processing browser_action: An
 unexpected property was found in the WebExtension manifest.
 I/Gecko   (24006): 1523904137700        addons.webextension.https-
 everywhere-eff at eff.org        WARN    Loading extension 'https-everywhere-
 eff at eff.org': Reading manifest: Error processing devtools_page: An
 unexpected property was found in the WebExtension manifest.
 I/Gecko   (24006): 1523904137700        DeferredSave.extensions.json
 DEBUG   Write succeeded
 }}}

 I see these same messages when I bundle https-everywhere 2018.03.13.

 Next, I'll try bundling https-e 5.2.20 with the newest Orfox version,
 because I'm curious if that reliably loads and if it rewrites URLs. If we
 can't get https-everywhere loading or working reliably, I'd rather remove
 it from Orfox in the next release. I don't want to give the false
 impression https-everywhere is loaded and working - when it isn't working
 in reality.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/25603#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online