[tbb-bugs] #23557 [Applications/Tor Browser]: rbm should download again an input file if it is not matching the expected sha256sum

[Tor Bug Tracker & Wiki]

#23557: rbm should download again an input file if it is not matching the expected
sha256sum
-------------------------------------------+-------------------------------
 Reporter:  boklm                          |          Owner:  boklm
     Type:  task                           |         Status:
                                           |  needs_revision
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201709  |  Actual Points:
Parent ID:                                 |         Points:
 Reviewer:                                 |        Sponsor:
-------------------------------------------+-------------------------------
Changes (by gk):

 * status:  needs_review => needs_revision
 * keywords:  tbb-rbm, TorBrowserTeam201709R => tbb-rbm,
               TorBrowserTeam201709


Comment:

 Hm, how is that supposed to work? I did the following:

 1) Added
 {{{
 -  - URL:
 https://people.torproject.org/~mikeperry/mirrors/sources/msvcr100.dll
 -    sha256sum:
 1221a09484964a6f38af5e34ee292b9afefccb3dc6e55435fd3aaf7c235d9067
 +  - URL: https://people.torproject.org/~gk/mirrors/sources/msvcr100.dll
 +    sha256sum:
 8793353461826fbd48f25ea8b835be204b758ce7510db2af631b28850355bd18
 }}}
 to my `tor-browser-build` instance.
 2) I verified that the sha256sum value is
 "1221a09484964a6f38af5e34ee292b9afefccb3dc6e55435fd3aaf7c235d9067" for the
 msvcr100.dll file I have in out/firefox
 3) I cloned `rbm` and applied the patch in this ticket
 4) I did /path/to/cloned_rbm/rbm fetch in my tor-browser-build directory
 5) I verified that the sha256sum value is still the same as in 2)

 If I am doing something wrong, let me know and just put that ticket back
 in `needs_review`.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23557#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online