[tbb-bugs] #23513 [Applications/Tor Browser]: When there is an error while starting a container, we don't clean up the container files

[Tor Bug Tracker & Wiki]

#23513: When there is an error while starting a container, we don't clean up the
container files
-------------------------------------+-------------------------------------
     Reporter:  boklm                |      Owner:  boklm
         Type:  defect               |     Status:  assigned
     Priority:  Medium               |  Milestone:
    Component:  Applications/Tor     |    Version:
  Browser                            |   Keywords:  tbb-rbm,
     Severity:  Normal               |  TorBrowserTeam201709
Actual Points:                       |  Parent ID:
       Points:                       |   Reviewer:
      Sponsor:                       |
-------------------------------------+-------------------------------------
 When there is an error starting a container (for instance due to #23039),
 we exit with many lines of errors such as:
 {{{
 cannot unlink file for /home/user/tor-browser-build/tmp/rbm-ZSCgVC/rbm-
 containers/5974d3088083038cf834dd21ae48552798cf288bc8949e376e617583dc8c2886/rootfs/lib/x86_64
 -linux-gnu/libnss_files.so.2: Permission denied at
 /usr/share/perl5/vendor_perl/File/Temp.pm line 1616.
 cannot restore permissions to 0120777 for /home/user/tor-browser-build/tmp
 /rbm-ZSCgVC/rbm-
 containers/5974d3088083038cf834dd21ae48552798cf288bc8949e376e617583dc8c2886/rootfs/lib/x86_64
 -linux-gnu/libnss_files.so.2: Permission denied at
 /usr/share/perl5/vendor_perl/File/Temp.pm line 1616.
 cannot unlink file for /home/user/tor-browser-build/tmp/rbm-ZSCgVC/rbm-
 containers/5974d3088083038cf834dd21ae48552798cf288bc8949e376e617583dc8c2886/rootfs/lib/x86_64
 -linux-gnu/libncursesw.so.5: Permission denied at
 /usr/share/perl5/vendor_perl/File/Temp.pm line 1616.
 }}}

 And the files from the container are not removed.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23513>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online