[tbb-bugs] #23228 [Applications/Tor Browser]: Build a Windows 64 toolchain based on mingw-w64

[Tor Bug Tracker & Wiki]

#23228: Build a Windows 64 toolchain based on mingw-w64
-------------------------------------------+-------------------------------
 Reporter:  boklm                          |          Owner:  tbb-team
     Type:  task                           |         Status:
                                           |  needs_revision
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201709  |  Actual Points:
Parent ID:  #20636                         |         Points:
 Reviewer:                                 |        Sponsor:
-------------------------------------------+-------------------------------
Changes (by gk):

 * keywords:  tbb-rbm, TorBrowserTeam201709R => tbb-rbm,
               TorBrowserTeam201709
 * status:  needs_review => needs_revision


Comment:

 Replying to [comment:4 boklm]:
 > An updated version of the patch is in commit
 b9904226f49a7c5a15c31e8466d7af57f8239538 from branch `bug_20636_v5`:
 > https://gitweb.torproject.org/user/boklm/tor-browser-
 build.git/commit/?h=bug_20636_v5&id=b9904226f49a7c5a15c31e8466d7af57f8239538
 >
 > In this new version of the patch we remove the
 `projects/mingw-w64/i686-w64-mingw32-*` files (which are now created in
 `projects/mingw-w64/build`).

 I think this needs revision as we need the relocation patch for 64-bit
 builds as well. Having the DLL characteristics showing proper output as
 the script we use does is necessary but not sufficient. We need an
 relocation table as well. Otherwise we land in the same situation as the
 bitcoin people (https://github.com/bitcoin/bitcoin/issues/8248) (I guess
 we can point them to our stuff to fix their problem?)).
 (comment:description:ticket:10505 summarizes the requirements, too)

 There is an old message on the mingw-w64 mailing list that summarizes all
 the pitfalls and requirements good:
 https://sourceforge.net/p/mingw-w64/mailman/message/31034877/

 skruffy wrote the patch for Tor Browser on Windows 32 platforms (PE) but
 we need to fix it for 64-bit (PE+ or probably PEP in `binutils` lingo). I
 think the way to go is to look at the `pep-dll.c` to understand what it
 does and add the missing things (I guess we could think about patching
 `pep.em` as well to rename `pe_dll_enable_reloc_section` to
 `pep_dll_enable_reloc_section` to make things more straightforward, but
 maybe not. I have not looked that close).

 Something for a different ticket I guess: Given that the script that
 checks the headers for ASLR is not enough to be sure we have ASLR enabled
 we should think about a better test.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23228#comment:5>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online