[tbb-bugs] #23425 [Applications/Tor Browser]: Build fails when running without a terminal

[Tor Bug Tracker & Wiki]

#23425: Build fails when running without a terminal
-------------------------------------+-------------------------------------
     Reporter:  boklm                |      Owner:  boklm
         Type:  defect               |     Status:  assigned
     Priority:  Medium               |  Milestone:
    Component:  Applications/Tor     |    Version:
  Browser                            |   Keywords:  tbb-rbm,
     Severity:  Normal               |  TorBrowserTeam201709
Actual Points:                       |  Parent ID:
       Points:                       |   Reviewer:
      Sponsor:                       |
-------------------------------------+-------------------------------------
 The Tor Browser build is failing with the following error when running
 without a terminal (such as in a cron job):
 {{{
 failed to set the terminal from the stdin: inappropriate ioctl for device
 }}}

 I think the reason is that in `projects/common/runc-config.json`, we have
 `process.terminal` set to `true`. We should set it to `false` when we are
 doing a build, but change it to `true` when we open a debugging shell.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23425>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online