[tbb-bugs] #23724 [Applications/Tor Browser]: NoScript restartless update breaks Security Slider and its icon disappears

[Tor Bug Tracker & Wiki]

#23724: NoScript restartless update breaks Security Slider and its icon disappears
--------------------------------------+--------------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Critical                  |     Resolution:
 Keywords:  noscript                  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------

Comment (by cypherpunks):

 Found https://dxr.mozilla.org/mozilla-
 esr52/rev/efa03deffad75f19fc598a757239e99b22a8bceb/toolkit/mozapps/extensions/internal/XPIProvider.jsm#5764,
 which may affect the update process as TBB has that cache disabled.

 `No chrome package registered for chrome://noscript/skin/icon32.png` is a
 leftover after `shutdown` bootstrap method and removal of manifest.
 Also it's possible to trigger
 {{{
 No chrome package registered for chrome://noscript/content/UISync.jsm
 NS_ERROR_FILE_NOT_FOUND: File error: Not found  UISync.jsm:32
 08:40:31.268 TypeError: Ci is undefined 1 Main.js:1507:11
 }}}

 Minor:
 {{{
 TypeError: ns is undefined MimeServiceParent.js:13:9
 [NoScript XSS] xss.reason.URIError: malformed URI sequence ---
 InjectionChecker.checkHTML at chrome://noscript/content/InjectionChecker.js?1bsc7269keutfaq7v55o:831:73
 InjectionChecker._checkRecursive at chrome://noscript/content/InjectionChecker.js?1bsc7269keutfaq7v55o:995:9
 InjectionChecker._checkRecursive at chrome://noscript/content/InjectionChecker.js?1bsc7269keutfaq7v55o:1044:11
 InjectionChecker.checkRecursive at chrome://noscript/content/InjectionChecker.js?1bsc7269keutfaq7v55o:990:12
 InjectionChecker.checkURL at chrome://noscript/content/InjectionChecker.js?1bsc7269keutfaq7v55o:939:12
 RequestWatchdog.prototype.filterXSS at chrome://noscript/content/RequestWatchdog.js?1bsc7269keutfaq7v55o:803:43
 RequestWatchdog.prototype.onHttpStart/<@chrome://noscript/content/RequestWatchdog.js?1bsc7269keutfaq7v55o:158:18
 DOSChecker.prototype.run at chrome://noscript/content/RequestWatchdog.js?1bsc7269keutfaq7v55o:1114:22
 RequestWatchdog.prototype.onHttpStart at chrome://noscript/content/RequestWatchdog.js?1bsc7269keutfaq7v55o:156:9
 MainParent["http-on-modify-
 request"].observe at chrome://noscript/content/MainParent.js?1bsc7269keutfaq7v55o:83:24
 }}}

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23724#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online