[tbb-bugs] #23724 [Applications/Tor Browser]: NoScript restartless update breaks Security Slider and its icon disappears

Tor Bug Tracker & Wiki blackhole at torproject.org
Sun Oct 8 14:05:58 UTC 2017


#23724: NoScript restartless update breaks Security Slider and its icon disappears
--------------------------------------+--------------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Critical                  |     Resolution:
 Keywords:  noscript                  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------------

Comment (by cypherpunks):

 Replying to [comment:11 cypherpunks]:
 ma1 keeps silence, so updating for rc3:
 > Icon jumps to the right.
 No jumping, but already broken TBB installations need a fixup.
 > {{{
 > 1507347423800 addons.xpi      DEBUG   Starting install of {73a6fe31
 -595d-460b-a920-fcc0f8843232} from
 https://addons.mozilla.org/firefox/downloads/latest-
 beta/noscript/addon-722-latest.xpi?src=ss
 > 1507347423900 addons.xpi      DEBUG   Addon {73a6fe31-595d-
 460b-a920-fcc0f8843232} will be installed as a packed xpi
 > CustomizableUI:Widget 'noscript-tbb' not found, unable to move
 CustomizableUI.jsm:1149
 > }}}
 > You start updating with removal of the tbb, and it has different id,
 correct?
 Patched.
 > {{{
 > 1507347424100 addons.xpi      DEBUG   Calling bootstrap method shutdown
 on {73a6fe31-595d-460b-a920-fcc0f8843232} version 5.1.1
 > can't access dead object  WebExt.js:17
 > }}}
 > What are you trying to 'tell' here?
 Still trying...
 > {{{
 > 1507347424200 addons.xpi      DEBUG   Removing manifest for C:\Tor
 Browser\Browser\TorBrowser\Data\Browser\profile.default\extensions\{73a6fe31
 -595d-460b-a920-fcc0f8843232}.xpi
 > Bootstrapped manifest not allowed to use 'component' directive.
 chrome.manifest:60
 > }}}
 > Why does it call HTTPS-Everywhere's chrome.manifest?
 You say Firefox re-registering manifests after removal of one, right?
 > {{{
 > 1507347424500 addons.xpi      DEBUG   Install of
 https://addons.mozilla.org/firefox/downloads/latest-
 beta/noscript/addon-722-latest.xpi?src=ss completed.
 > No chrome package registered for
 chrome://noscript/locale/about.properties
 > 1507347424600 addons.xpi      DEBUG   Registering manifest for C:\Tor
 Browser\Browser\TorBrowser\Data\Browser\profile.default\extensions\{73a6fe31
 -595d-460b-a920-fcc0f8843232}.xpi
 > }}}
 > Firefox wants better code.
 It wants registering addon first.
 {{{
 No chrome package registered for chrome://noscript/skin/icon32.png
 }}}
 > {{{
 > 1507347424600 addons.xpi      DEBUG   Calling bootstrap method startup
 on {73a6fe31-595d-460b-a920-fcc0f8843232} version 5.1.2rc2
 > TypeError: ABE is undefined[Learn More]  ABE.js:1198:21
 > TypeError: WAN is undefined[Learn More]  ABE.js:1186:23
 > }}}
 > Heh.
 Patched.
 > {{{
 > No matching message handler for the given recipient.
 MessageChannel.jsm:621
 > Torbutton NOTE: Failed to update NoScript status for security setings:
 TypeError: win.noscriptOverlay is undefined
 > 1507347425700 addons.webextension.{73a6fe31-595d-460b-a920-fcc0f8843232}
 WARN    Loading extension '{73a6fe31-595d-460b-a920-fcc0f8843232}':
 Reading manifest: Error processing permissions.1: Unknown permission
 "privacy"
 > }}}
 > So we have a short period of time with broken settings, and then
 It's enough to break the Security Slider.
 > {{{
 > Torbutton INFO: Updated NoScript status for security settings
 > }}}
 > But why do we have ClearClick checkbox still selected?
 Patched.
 But why doesn't it honor Forbid A/V settings?

 Unrelated issues:
 {{{
 06:51:47.366 TypeError: Cu is undefined 1 PasteHandler.jsm:16:3
 }}}
 Misc.
 {{{
 10:05:32.529 about:blank : Unable to run script because scripts are
 blocked internally. 1 (unknown)
 }}}
 Why does NoScript try to do that?

 gk:
 {{{
 13:53:06.588 NoScript could not disable scripts for system global [System
 Principal] 1 WinScript.js:13:11
 }}}
 See ticket:20752#comment:2:
 > BTW, does the Tor Browser have its own customized mandatory whitelist?
 If so, you should add [System+Principal] (yes, with the "+" instead of "
 "), which is in NoScript's default and should fix half of the cases.
 {{{
 02:05:11.786 TypeError: overlayQueue is undefined 1 Restartless.jsm:134:5
 }}}
 Torbutton misses NoScript...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23724#comment:17>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online


More information about the tbb-bugs mailing list