[tbb-bugs] #23724 [Applications/Tor Browser]: NoScript restartless update breaks Security Slider and its icon disappears

[Tor Bug Tracker & Wiki]

#23724: NoScript restartless update breaks Security Slider and its icon disappears
--------------------------------------+-----------------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_information
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Critical                  |     Resolution:
 Keywords:  noscript                  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+-----------------------------------
Changes (by cypherpunks):

 * status:  new => needs_information


Comment:

 Icon jumps to the right.
 {{{
 1507347423800   addons.xpi      DEBUG   Starting install of {73a6fe31
 -595d-460b-a920-fcc0f8843232} from
 https://addons.mozilla.org/firefox/downloads/latest-
 beta/noscript/addon-722-latest.xpi?src=ss
 1507347423900   addons.xpi      DEBUG   Addon {73a6fe31-595d-
 460b-a920-fcc0f8843232} will be installed as a packed xpi
 CustomizableUI:Widget 'noscript-tbb' not found, unable to move
 CustomizableUI.jsm:1149
 }}}
 You start updating with removal of the tbb, and it has different id,
 correct?
 {{{
 1507347424100   addons.xpi      DEBUG   Calling bootstrap method shutdown
 on {73a6fe31-595d-460b-a920-fcc0f8843232} version 5.1.1
 can't access dead object  WebExt.js:17
 }}}
 What are you trying to 'tell' here?
 {{{
 1507347424200   addons.xpi      DEBUG   Removing manifest for C:\Tor
 Browser\Browser\TorBrowser\Data\Browser\profile.default\extensions\{73a6fe31
 -595d-460b-a920-fcc0f8843232}.xpi
 Bootstrapped manifest not allowed to use 'component' directive.
 chrome.manifest:60
 }}}
 Why does it call HTTPS-Everywhere's chrome.manifest?
 {{{
 1507347424500   addons.xpi      DEBUG   Install of
 https://addons.mozilla.org/firefox/downloads/latest-
 beta/noscript/addon-722-latest.xpi?src=ss completed.
 No chrome package registered for chrome://noscript/locale/about.properties
 1507347424600   addons.xpi      DEBUG   Registering manifest for C:\Tor
 Browser\Browser\TorBrowser\Data\Browser\profile.default\extensions\{73a6fe31
 -595d-460b-a920-fcc0f8843232}.xpi
 }}}
 Firefox wants better code.
 {{{
 1507347424600   addons.xpi      DEBUG   Calling bootstrap method startup
 on {73a6fe31-595d-460b-a920-fcc0f8843232} version 5.1.2rc2
 TypeError: ABE is undefined[Learn More]  ABE.js:1198:21
 TypeError: WAN is undefined[Learn More]  ABE.js:1186:23
 }}}
 Heh.
 {{{
 No matching message handler for the given recipient.
 MessageChannel.jsm:621
 Torbutton NOTE: Failed to update NoScript status for security setings:
 TypeError: win.noscriptOverlay is undefined
 1507347425700   addons.webextension.{73a6fe31-595d-460b-a920-fcc0f8843232}
 WARN    Loading extension '{73a6fe31-595d-460b-a920-fcc0f8843232}':
 Reading manifest: Error processing permissions.1: Unknown permission
 "privacy"
 TypeError: Date is undefined[Learn More]  ClearClickHandler.js:318:9
 }}}
 So we have a short period of time with broken settings, and then
 {{{
 Torbutton INFO: Updated NoScript status for security settings
 }}}
 But why do we have ClearClick checkbox still selected?

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23724#comment:11>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online