[tbb-bugs] #23724 [Applications/Tor Browser]: NoScript restartless update breaks Security Slider and its icon disappears

[Tor Bug Tracker & Wiki]

#23724: NoScript restartless update breaks Security Slider and its icon disappears
--------------------------------------+--------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  High                      |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Critical                  |     Resolution:
 Keywords:  noscript                  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by gk):

 Replying to [comment:3 cypherpunks]:
 > > I wonder if that only happend when updating from a version with the
 new NoScript code to a newer one, like it happened from 5.1.0 to 5.1.1
 while the problem is not visible when updating from the old code (e.g.
 5.0.10) to 5.1.1 directly.
 > comment 23 is the answer, 22 is by another cpunk. NoScript resets to its
 defaults, not TBB's!

 Yes. This results in e.g.
 {{{
 TypeError: ABE is undefined[Weitere Informationen]  ABE.js:1198:21
 TypeError: WAN is undefined[Weitere Informationen]  ABE.js:1186:23
 }}}
 ma1: I just reproduced this with a clean new profile in a vanilla Firefox
 52 ESR. This is no Tor Browser issue. Could you please look at that one
 before pushing a new NoScript update? Here are my steps to reproduce:

 1) Create a new profile to be used with a Firefox 52 ESR
 2) Copy a NoScript 5.0.10 into the extensions directory and start the
 browser with the new profile
 3) NoScript should be ready, close the browser if so
 4) Copy NoScript 5.1.0 over 5.0.10 and create a preferences folder in the
 profile directory + customize NoScript by copying
 https://gitweb.torproject.org/builders/tor-browser-bundle.git/tree/Bundle-
 Data/linux/Data/Browser/profile.default/preferences/extension-overrides.js
 into it. That just flips some NoScript defaults
 5) Restart and make sure it is working
 6) Now, update to NoScript 5.1.1 (via the in-browser extension update
 means)
 7) NoScript's prefs are reset and the errors in the browser console pop up
 8) After restart it seems NoScript is working again as expected.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23724#comment:4>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online