[tbb-bugs] #21925 [Applications/Tor Browser]: Tor Browser based on ESR52 can't get built with ASan and FORTIFY_SOURCE

[Tor Bug Tracker & Wiki]

#21925: Tor Browser based on ESR52 can't get built with ASan and FORTIFY_SOURCE
--------------------------------------+--------------------------
 Reporter:  gk                        |          Owner:  tbb-team
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:                            |  Actual Points:
Parent ID:  #21998                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+--------------------------

Comment (by gk):

 Replying to [comment:1 boklm]:
 > Reverting the patch from
 https://bugzilla.mozilla.org/show_bug.cgi?id=1279096 is fixing the build
 issue.

 I guess that's because the ASan that is shipped with GCC 5.4.0 is old
 enough to not hit this Mozilla bug. Assuming this is indeed and LLVM 3.8
 issue then we can see when this would hit compiling with GCC

 LLVM 3.7 rev 246985
 LLVM 3.8 rev 271801

 GCC 5.4.0 rev 221802
 GCC 6.4.0 rev 253555
 GCC 7.2.0 rev 285547

 So, when switching to GCC 6.4.0 we might still be good. But as soon as we
 use GCC 7.x that would not be the case anymore. Anyway, now that we know
 what is causing it we should probably file a Mozilla bug to get the GCC
 bits right.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21925#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online