[tbb-bugs] #23561 [Applications/Tor Browser]: Fix nsis builds for Windows 64

Tor Bug Tracker & Wiki blackhole at torproject.org
Wed Nov 8 10:20:49 UTC 2017

#23561: Fix nsis builds for Windows 64
 Reporter:  boklm                          |          Owner:  boklm
     Type:  task                           |         Status:  needs_review
 Priority:  Medium                         |      Milestone:
Component:  Applications/Tor Browser       |        Version:
 Severity:  Normal                         |     Resolution:
 Keywords:  tbb-rbm, TorBrowserTeam201711  |  Actual Points:
Parent ID:  #20636                         |         Points:
 Reviewer:                                 |        Sponsor:

Comment (by boklm):

 Replying to [comment:6 boklm]:
 > I pushed a more simple version of the patch in branch `bug_23561_v2`:
 > https://gitweb.torproject.org/user/boklm/tor-browser-

 Actually this patch doesn't work as expected. This `windows-x86_64:
 windows-i686` line only apply inside projects/nsis, but not on the
 dependencies, such as the compiler, so it will be using the 64bit

 So we should use the patch from `bug_23561`. Sorry for the confusion.

 > The tor-browser output filename is the same in both branches, so the
 result should be the same:
 > {{{
 > ./rbm/rbm showconf tor-browser filename --target torbrowser-windows-i686
 --target alpha
 > tor-browser-7.5a7-windows-i686-328442
 > }}}

 I used `--target torbrowser-windows-i686` instead of `--target torbrowser-
 windows-x86_64` here. If I use `--target torbrowser-windows-x86_64` then I
 get a different tor-browser filename in the 2 branches.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23561#comment:7>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list