[tbb-bugs] #24159 [Applications/Tor Browser]: The Torbutton version check does not deal properly with platform specific checks

[Tor Bug Tracker & Wiki]

#24159: The Torbutton version check does not deal properly with platform specific
checks
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  High                                 |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Major                                |     Resolution:
 Keywords:  tbb-torbutton, TorBrowserTeam201711  |  Actual Points:
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------

Comment (by gk):

 Replying to [comment:1 mcs]:
 > We could use Services.appinfo.OS, but it returns strings like Darwin and
 WINNT.

 Well, we could easily translate that into "MacOS" and "Windows". I think
 we should make only client side changes, i.e. in Torbutton. For one this
 makes the fix less complex. And secondly, there might be third parties
 relying on the recommended versions file as it is right now.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/24159#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online