[tbb-bugs] #20680 [Applications/Tor Browser]: Rebase Tor Browser patches to 52 ESR

Tor Bug Tracker & Wiki blackhole at torproject.org
Fri Mar 31 14:44:16 UTC 2017

#20680: Rebase Tor Browser patches to 52 ESR
 Reporter:  arthuredelstein                      |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  new
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  ff52-esr, tbb-7.0-must,              |  Actual Points:
  TorBrowserTeam201703, tbb-7.0-must-nightly     |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
                                                 |  Sponsor4

Comment (by gk):

 Here is the next batch:

 `43d4fc730a6216433c059345111c5fe9d11deae6`: looks good to me. mcs/brade
 could you have a second look?
 `2b52030695f445b2f924a4442efeb6d49ee9fde2`: good
 `8faf75d71705cdf891e6bedfc10ef8e93429d7fa`: good
 `88e6c45cd16afdc26c1ec0ed7c887e5844c0374e`: good
 `7ba9b10dab17c534933ec3441ff646b236445fbf`: good
 `e8503c86d6ce4c286f54488b95f63447f9184c97`: good


 1) the last bit in setLoginSavingEnabled() seems to be missing?


 1) Why do we have:

 +    nsCOMPtr<nsIToolkitProfile> profile;
 +    rv = aProfileSvc->GetProfileByName(nsDependentCString(arg),
 +                                       getter_AddRefs(profile));
 +    if (NS_SUCCEEDED(rv)) {
 +      ProfileStatus status = CheckProfileWriteAccess(profile);
 +      if (PROFILE_STATUS_OK != status)
 +        return ProfileErrorDialog(profile, status, nullptr, aNative,
 +    }

 now? It seems the relevant code around it does not have changed enough
 that this is self-explaining to me.


 1) Why is MOZ_UTF16() not good enough anymore? Does the code not build
 with it anymore?

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20680#comment:35>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list