[tbb-bugs] #21723 [Applications/Tor Browser]: Fix inconsistent generation of MOZ_MACBUNDLE_ID

[Tor Bug Tracker & Wiki]

#21723: Fix inconsistent generation of MOZ_MACBUNDLE_ID
--------------------------------------+------------------------------
 Reporter:  teor                      |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_review
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  TorBrowserTeam201703R     |  Actual Points:
Parent ID:  #17670                    |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------

Comment (by teor):

 Replying to [comment:2 mcs]:
 > Thanks for working on this. I have not tested this, but a quick glance
 at the uses of MOZ_MACBUNDLE_NAME within the browser code tells me we may
 not want to force it to lowercase because doing so will change our .app
 bundle from TorBrowser.app to torbrowser.app which is is less OSX-like and
 may also require changes to our packaging scripts, etc.

 You're right, I didn't notice that this was a different variable.
 I reverted this change.

 > MOZ_MACBUNDLE_ID should definitely be fixed though,

 I have revised this patch in my branch fix-macos-bundle-id-v2.
 It now removes all invalid characters, not just spaces.

 I tested it using:
 `echo "Tor Browser" | tr 'A-Z' 'a-z' | tr -dc 'a-z-'`
 on macOS and Ubuntu.

 The `[]` are unnecessary on modern tr, and lead to unexpected results when
 used with `tr -d`.

 `a-z` might not work when configure is run in a non-English locale, we can
 replace them with octal if this is a concern. (I expect this is not a
 practical issue, because otherwise the existing `tr [A-Z] [a-z]` would
 have failed.)

 > and I like org.torproject.torbrowser better than org.mozilla.torbrowser
 (but that will require a larger patch or scarier build config changes).

 This can be implemented by passing the following argument to Firefox's
 configure:
 `--with-distribution-id=org.torproject`

 Please see my branch `distribution-torproject` on
 https://github.com/teor2345/tor-browser-build.git for this change.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21723#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online