[tbb-bugs] #21396 [Applications/Tor Browser]: Torbutton breaks Session Manager addon

[Tor Bug Tracker & Wiki]

#21396: Torbutton breaks Session Manager addon
-------------------------------------------------+-------------------------
 Reporter:  HolD                                 |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:
                                                 |  reopened
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:
 Keywords:  tbb-6.5-regression,                  |  Actual Points:
  TorBrowserTeam201703R, GeorgKoppen201702       |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * status:  closed => reopened
 * resolution:  fixed =>


Comment:

 Gah, I should have thought more about `uriFingerprinting` being available
 (and not follow your advice blindly ;) ). See my fixup in my
 `bug_21396_v3`
 (https://gitweb.torproject.org/user/gk/torbutton.git/commit/?h=bug_21396_v3&id=2049d704d464907b6c58123f8c98df976f4f36e4).

 `uriFingerprinting` was available because it got put into global scope by
 `this.uriFingerprinting` inside the handler function. Does that and the
 fixup make sense? The new code fixes that problem and works now as well.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/21396#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online