[tbb-bugs] #23065 [Applications/Tor Browser]: Tor Browser UI hang on macOS when closing window

[Tor Bug Tracker & Wiki]

#23065: Tor Browser UI hang on macOS when closing window
------------------------------------------+----------------------
     Reporter:  teor                      |      Owner:  tbb-team
         Type:  defect                    |     Status:  new
     Priority:  Medium                    |  Milestone:
    Component:  Applications/Tor Browser  |    Version:
     Severity:  Normal                    |   Keywords:  hang
Actual Points:                            |  Parent ID:
       Points:                            |   Reviewer:
      Sponsor:                            |
------------------------------------------+----------------------
 I am using Tor Browser 7.0.2 on macOS 10.12.5.

 I closed a Tor Browser window that was waiting for a network connection.
 It hung the entire UI with the following call stack:

     1075 Thread_8568   DispatchQueue_1: com.apple.main-thread  (serial)
     + 1075 ???  (in XUL)  load address 0x10c5d0000 + 0x1c06472
 [0x10e1d6472]
     +   1075 -[NSApplication(NSEvent)
 _nextEventMatchingEventMask:untilDate:inMode:dequeue:]  (in AppKit) + 2796
 [0x7fff965897ee]
     +     1075 _DPSNextEvent  (in AppKit) + 1120  [0x7fff95e0da54]
     +       1075 _BlockUntilNextEventMatchingListInModeWithFilter  (in
 HIToolbox) + 71  [0x7fff97874b26]
     +         1075 ReceiveNextEventCommon  (in HIToolbox) + 432
 [0x7fff97874cf1]
     +           1075 RunCurrentEventLoopInMode  (in HIToolbox) + 240
 [0x7fff97874ebc]
     +             1075 CFRunLoopRunSpecific  (in CoreFoundation) + 420
 [0x7fff98314114]
     +               1075 __CFRunLoopRun  (in CoreFoundation) + 934
 [0x7fff98314716]
     +                 1075 __CFRunLoopDoSources0  (in CoreFoundation) +
 557  [0x7fff9831521d]
     +                   1075
 __CFRUNLOOP_IS_CALLING_OUT_TO_A_SOURCE0_PERFORM_FUNCTION__  (in
 CoreFoundation) + 17  [0x7fff98334321]
     +                     1075 ???  (in XUL)  load address 0x10c5d0000 +
 0x1bd7434  [0x10e1a7434]
     +                       1075 -[NSView removeFromSuperview]  (in
 AppKit) + 465  [0x7fff95df2587]
     +                         1075 -[NSView _setWindow:]  (in AppKit) +
 2575  [0x7fff95def960]
     +                           1075 -[NSSurface setWindow:]  (in AppKit)
 + 53  [0x7fff960159ea]
     +                             1075 -[NSSurface _disposeSurface]  (in
 AppKit) + 152  [0x7fff96015e3b]
     +                               1075 -[NSNotificationCenter
 postNotificationName:object:userInfo:]  (in Foundation) + 66
 [0x7fff99d0b677]
     +                                 1075 _CFXNotificationPost  (in
 CoreFoundation) + 604  [0x7fff982e655c]
     +                                   1075 -[_CFXNotificationRegistrar
 find:object:observer:enumerator:]  (in CoreFoundation) + 1827
 [0x7fff982e7523]
     +                                     1075
 ___CFXNotificationPost_block_invoke  (in CoreFoundation) + 50
 [0x7fff9832a0c2]
     +                                       1075 _CFXRegistrationPost  (in
 CoreFoundation) + 427  [0x7fff9832a35b]
     +                                         1075
 __CFNOTIFICATIONCENTER_IS_CALLING_OUT_TO_AN_OBSERVER__  (in
 CoreFoundation) + 12  [0x7fff9832a45c]
     +                                           1075 CGLClearDrawable  (in
 OpenGL) + 41  [0x7fff9d2d8afe]
     +                                             1075
 _pthread_mutex_lock_slow  (in libsystem_pthread.dylib) + 285
 [0x7fffadcab519]
     +                                               1075
 _pthread_mutex_lock_wait  (in libsystem_pthread.dylib) + 100
 [0x7fffadcaddfa]
     +                                                 1075
 __psynch_mutexwait  (in libsystem_kernel.dylib) + 10  [0x7fffadbc2c22]

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23065>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online