[tbb-bugs] #20680 [Applications/Tor Browser]: Rebase Tor Browser patches to 52 ESR

[Tor Bug Tracker & Wiki]

#20680: Rebase Tor Browser patches to 52 ESR
--------------------------------------------+--------------------------
 Reporter:  arthuredelstein                 |          Owner:  tbb-team
     Type:  defect                          |         Status:  new
 Priority:  Medium                          |      Milestone:
Component:  Applications/Tor Browser        |        Version:
 Severity:  Normal                          |     Resolution:
 Keywords:  ff52-esr, TorBrowserTeam201702  |  Actual Points:
Parent ID:                                  |         Points:
 Reviewer:                                  |        Sponsor:  Sponsor4
--------------------------------------------+--------------------------

Comment (by gk):

 Replying to [comment:19 arthuredelstein]:
 > Replying to [comment:15 mcs]:
 > > Replying to [comment:14 gk]:
 > > > Replying to [comment:13 gk]:
 > > > > mcs/brade: the patch for #15640 got finally included in the big
 canvas one. Do you think it would be worthwhile noting this in the commit
 message as well? I saw we mentioned a bunch of other bugs there too and
 thought it might help clarifying things in case one is wondering where
 that patch is gone (as I did while updating the design doc).
 > > >
 > > > I feel mentioning our adapted logic from #17446 would be good as
 well.
 > >
 > > Yes, we should mention both of those tickets in the new #6253 commit
 message.
 > > Arthur, can you add them when you create a new ESR52 branch or is that
 not something you will need to do soon?
 >
 > I have added mention of both of these tickets in our #6253 commit
 message.
 >
 > Replying to [comment:18 mcs]:
 > > I just attached a fix that Kathy and I needed to make in order to
 build successfully on Linux (probably also needed for Windows).
 >
 > Thanks -- added to my branch.
 >
 > Here's the latest branch:
 > https://github.com/arthuredelstein/tor-browser/commits/20680+3

 Could you adapt the commit message for the patch for #1517 as well? We
 don't round keyboard events to 250ms, see #19186.

 While looking a bit over the patches it occurred to me we want to test
 whether we still need the patch for #19212.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/20680#comment:20>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online