[tbb-bugs] #10573 [Applications/Tor Browser]: `nsILocalFile` should be replaced with `nsIFile` in our extensions

Tor Bug Tracker & Wiki blackhole at torproject.org
Mon Dec 4 08:27:00 UTC 2017

#10573: `nsILocalFile` should be replaced with `nsIFile` in our extensions
 Reporter:  cypherpunks               |          Owner:  tbb-team
     Type:  defect                    |         Status:  needs_revision
 Priority:  Medium                    |      Milestone:
Component:  Applications/Tor Browser  |        Version:
 Severity:  Minor                     |     Resolution:
 Keywords:  tbb-easy                  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
Changes (by gk):

 * status:  needs_review => needs_revision


 Thanks aruna1234: Could you create a proper `git` patch for review? The
 commit message should contain the bug number and what you did, for
 instance "Bug 10573: Replace deprecated nsILocalFile with nsIFile".

 You can start by cloning the code repositories we use, for Tor Launcher
 you could do
 `git clone https://git.torproject.org/tor-launcher` and then you write
 your patch and commit it that repository. You can then create a properly
 formatted patch by running `git format-patch -p -1` and attach that one
 for review.

 It seems to me we have a similar issue in our Torbutton code. You can fix
 similarly by starting with cloning the Torbutton repository with `git
 clone https://git.torproject.org/torbutton`.

Ticket URL: <https://trac.torproject.org/projects/tor/ticket/10573#comment:9>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online

More information about the tbb-bugs mailing list