[tbb-bugs] #22618 [Applications/Tor Browser]: Downloading pdf file via file:/// is stalling if the external helper dialog is enabled

[Tor Bug Tracker & Wiki]

#22618: Downloading pdf file via file:/// is stalling if the external helper dialog
is enabled
-------------------------------------------------+-------------------------
 Reporter:  gk                                   |          Owner:  tbb-
                                                 |  team
     Type:  defect                               |         Status:  closed
 Priority:  Medium                               |      Milestone:
Component:  Applications/Tor Browser             |        Version:
 Severity:  Normal                               |     Resolution:  fixed
 Keywords:  tbb-7.0-issues, tbb-regression,      |  Actual Points:
  tbb-e10s, TorBrowserTeam201708R, tbb-backport  |
Parent ID:                                       |         Points:
 Reviewer:                                       |        Sponsor:
-------------------------------------------------+-------------------------
Changes (by gk):

 * keywords:  tbb-7.0-issues, tbb-regression, tbb-e10s,
     TorBrowserTeam201708R =>
     tbb-7.0-issues, tbb-regression, tbb-e10s, TorBrowserTeam201708R, tbb-
     backport
 * status:  needs_review => closed
 * resolution:   => fixed


Comment:

 Replying to [comment:13 mcs]:
 > Here is a fixup patch for torbutton:
 >
 https://gitweb.torproject.org/user/brade/torbutton.git/commit/?h=bug21766-fixup-01
 >
 > And here is one for the browser:
 > https://gitweb.torproject.org/user/brade/tor-
 browser.git/commit/?h=bug21766-fixup-01
 >
 > Kathy and I are not sure how best to handle the commit message. We did a
 `git commit --squash ...` but we then wrote the commit message that we
 think should be preserved when rebasing is done (when the three Bug 19273
 commits will be squashed together). Hopefully what we did will work, but
 please let us know if we should do something different.

 That's okay. I'll take that into account when rebasing (actually I guess
 af0ca6a886c7a9149602a6588cc4d44874f2fee9 should have been a `fixup` commit
 and not a `revert` one, but that should be no issue when rebasing either).

 Merge both, the Torbutton patch to `master` (commit
 8e5e391c71d6c5f3ae80c88e45d1e8522f981214) and the tor-browser one to `tor-
 browser-52.3.0esr-7.5-2` (commit
 9ecbfca98dc5488527495e3bfde0fabf75a8529a). Closing this and a bunch of
 related tickets, yay! + marking this as a potential backport candidate
 although it's a big patch.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/22618#comment:14>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online